Open
Conversation
|
@adastreamer thanks for that, any plans to write the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys!
Just want to add a few important endpoints which are available in docker-engine since the version 1.12
Let me know any thoughts.
Also I have one question: why all the tests are so massive? They're running too long and I can't realize why even the docker is required! So, this app is just a simple REST API client, it should not testing the docker functionality! Imho strictly should not! Why not to write simple mock-objects of supposed responses? In this case it's possible to track the Docker API versions. Apologize if I'm missing something, just trying to understand what's going on.